Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Lint & Format & Types #1

Merged
merged 4 commits into from
Mar 13, 2024
Merged

[CI] Lint & Format & Types #1

merged 4 commits into from
Mar 13, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented Mar 12, 2024

This is a big change

  • moving away from bun to npm.
  • Adding and enforcing eslint with strict configuration regarding types and format.

I wanted to add tests, but there was conflict between running the scripts and running tests (I suppose this was what bun was giving us). Example, I was able to remove "type": "module" from package json to get one working, but then the other one wouldn't work...

@bh2smith bh2smith requested a review from microchipgnu March 12, 2024 14:18
@bh2smith bh2smith merged commit 687d39e into main Mar 13, 2024
2 checks passed
@bh2smith bh2smith deleted the format-types branch March 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant